[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

Wed Jan 20 08:16:41 PST 2021

t-tye requested changes to this revision.
t-tye added a comment.
This revision now requires changes to proceed.

In D93525#2509796 <https://reviews.llvm.org/D93525#2509796>, @jdoerfert wrote:

>> At the moment this patch defines compatibility as exact string match of bundler entry ID.
>> [...]
>> Supporting target ID requires little more work and discussion.
>
> Let's get this in first, then revisit target ID support as we need it.

I do not think this patch should ignore target ID as that is now upstreamed and documented. What is involved in correcting the compatibility test to be correct by the target ID rules? There are examples of doing this in all the runtimes and I can help if that is useful.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93525/new/

https://reviews.llvm.org/D93525