[PATCH] D94727: [clangd] Retire some flags for uncontroversial, stable features.

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdServer.h:147
 
-    bool SuggestMissingIncludes = false;
-
----------------
hokein wrote:
> our internal client explicitly set this to `true`, so we need a migration plan for this, otherwise this would break our build of internal client during the integration, a possible plan is
> 
> 1. set this flag to true by default in upstream, wait for the integration
> 2. remove the explicit setting internally
> 3. remove this flag (this patch) in upstream
> 
> Or just remove the flag internally, then land this patch in upstream (but internal release has to pick-up these two together)
Discussed offline - there's no reason to block for out-of-tree clients here.

(We're removing support for a configuration - SuggestMissingIncludes = false - which is AFAIK unused anywhere. And we're removing the flag as well, but this is a trivial API change to adapt to)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94727/new/

https://reviews.llvm.org/D94727