[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

Pushpinder Singh via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 20 01:49:43 PST 2021


pdhaliwal updated this revision to Diff 317810.
pdhaliwal added a comment.
Herald added a subscriber: mgorny.

> Won't this just prevent us from building clang due to the missing cmake changes?

It compiles and builds fine, however, I wasn't actually aware such sanity checking being present. It turns out
the unknown files inside llvm/ will lead cmake to report error but such reporting will not happen inside clang. Maybe such checks
were not enabled inside clang. Anyways thanks for pointing out. I will keep that in mind in future.

The idea for this patch was basically to introduce AMDGPUToolChain classes without much of the functionality in order
to keep its size in check. And the second patch would have integrated the toolchain with driver along with testing.
But during the intermediate time of the two patches, bare files would have existed (never built and tested).

I have updated this patch to now include somewhat functional driver along with tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94961/new/

https://reviews.llvm.org/D94961

Files:
  clang/lib/Driver/CMakeLists.txt
  clang/lib/Driver/Driver.cpp
  clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp
  clang/lib/Driver/ToolChains/AMDGPUOpenMP.h
  clang/test/Driver/amdgpu-openmp-toolchain.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94961.317810.patch
Type: text/x-patch
Size: 23463 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210120/eeda1f59/attachment-0001.bin>


More information about the cfe-commits mailing list