[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

[David Blaikie via Phabricator via cfe-commits]

dblaikie added inline comments.


================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1050-1052
+  // Don't include a linkage name in line tables only, except to differentiate
+  // between lambdas.
+  if (CGM.getCodeGenOpts().hasReducedDebugInfo() || RD->isLambda())
----------------
rnk wrote:
> We discussed giving lambdas display names as an alternative to doing this.
Should this be only for CodeView (due to CV's need for functions to be distinct in some way)? Adding the linkage name could increase debug info size for DWARF consumers unnecessarily


================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3738
                                                              llvm::DIFile *F) {
-  if (!D || DebugKind <= codegenoptions::DebugLineTablesOnly)
+  if (!D)
     // Create fake but valid subroutine type. Otherwise -verify would fail, and
----------------
And here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95001/new/

https://reviews.llvm.org/D95001