[PATCH] D94979: [CGExpr] Honor getCharWidth() in ConstantAggregateBuilderUtils

[Bjorn Pettersson via Phabricator via cfe-commits]

bjope added a comment.

In D94979#2507242 <https://reviews.llvm.org/D94979#2507242>, @lebedev.ri wrote:

> As far as i recall, all RFC's about LLVM support for non-8-bit char targets didn't end in favor of the proposal
> I'd say that until there's general consensus/buy-in (including testing path), cleaning stuff up will only confuse things.
> CC @jfb

Well, I haven't even added reviewers. But if it hurts so much maybe I should abandon it ;-)

But from my point of view this patch isn't really adding non-8-bit char support. But there is an abstraction in clang (such as ASTContext) with getCharWidth(), toCharUnitsFromBits() etc. And it is confusing when things don't add up (such as calculating the number of chars using toCharUnitsFromBits(), indirectly using getCharWidth(), and then later ignoring it and assuming that the char width is 8. I don't see how being more consistent is more confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94979/new/

https://reviews.llvm.org/D94979