[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

Adam Czachorowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 19 07:17:03 PST 2021


adamcz accepted this revision.
adamcz added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/Quality.cpp:477
 
+  if (MainFileRefs >= 2) {
+    // E.g.: (2, 1.12), (9, 2.0), (48, 3.0).
----------------
Can you add a comment explaining how you chose those magic numbers? So that in the future, when someone needs to change it somehow, they have an idea of where this came from.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94927/new/

https://reviews.llvm.org/D94927



More information about the cfe-commits mailing list