[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

[Denys Petrov via Phabricator via cfe-commits]

ASDenysPetrov added a comment.

@vsavchenko

> F14534708: report-6ea17d.html <https://reviews.llvm.org/F14534708>

I checked it in IE. It doesn't draw arrows. Investigate this, please.



================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:147
+bool isArrowPiece(const PathDiagnosticPiece &P) {
+  return isa<PathDiagnosticControlFlowPiece>(P) && P.getString().empty();
+}
----------------
Are you sure that **non-arrow** piece **always** has **non-empty** string representation? Can this give us a false positive result?


================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:458
   }
   if (event.key == "S") {
     var checked = document.getElementsByName("showCounterexample")[0].checked;
----------------
Seems like this shortcut works only with the capital **S** aka //shift+s//
Should we support any **s** state?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92639/new/

https://reviews.llvm.org/D92639