[PATCH] D91944: OpenMP 5.0 metadirective

Mon Jan 18 10:19:14 PST 2021

jdoerfert added a comment.

In D91944#2504924 <https://reviews.llvm.org/D91944#2504924>, @protze.joachim wrote:

> I found two issues with this patch regarding the `default` clause:
>
> - The spec does not require a default clause. I get `error: expected expression` if I omit a default clause. The error is gone if I add `default()`.
> - The spec does not allow an empty `default()` clause, but rather expects `default(nothing)`or omission of the default clause. This patch accepts the empty default clause.

There are various issues with this patch. We will fix them afterwards. The patch provides a lot of infrastructure we need. Please provide the problematic cases in a bug.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91944/new/

https://reviews.llvm.org/D91944