[PATCH] D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier
Adam Czachorowski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 18 08:12:21 PST 2021
adamcz added inline comments.
================
Comment at: clang/lib/AST/DeclBase.cpp:986
+ isa<ClassScopeFunctionSpecializationDecl>(this) ||
+ isa<LifetimeExtendedTemporaryDecl>(this))
return true;
----------------
hokein wrote:
> nit: personally I'd keep the old format style, just appending the new case.
I like the old formatting a little better too, but this is what clang-format wants to do and I think keeping the code clang-format clean is more valuable in this case. Otherwise everyone submitting here must ignore/silence formatting errors and can no longer auto-format this file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94804/new/
https://reviews.llvm.org/D94804
More information about the cfe-commits
mailing list