[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

Mon Jan 18 06:48:50 PST 2021

vsavchenko added a comment.

In D93630#2490034 <https://reviews.llvm.org/D93630#2490034>, @aaron.ballman wrote:

> In D93630#2486574 <https://reviews.llvm.org/D93630#2486574>, @aaron.ballman wrote:
>
>> I'm going to see if I can run the patch against our internal corpus here at work to see if it shakes out any breakages to real world code. I've not tried this before, so I have no idea how long it will take before I get results back, but I'll let you know when I have them.
>
> The tests finally finished over the weekend and came back with no new failures -- that gives me a lot more confidence that this doesn't accidentally change behavior in cases users are likely to hit (at least in C and C++).

That is amazing, thanks for doing that!  I'll make sure that it works for Obj-C/Obj-C++.

> I think the next steps are to clean up the tests and then coordinate with the GCC folks to ensure they don't have any strong objections we should be aware of.

I'll clean up the tests!  But, unfortunately, I couldn't proceed with GCC folks.  I asked around and I'm not allowed to do that (company rules).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93630/new/

https://reviews.llvm.org/D93630