[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

Quentin Chateau via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 17 09:15:07 PST 2021


qchateau added a comment.

You're right, I probably got carried away for the sake of completeness. Allocating extra memory for a feature nobody is going to use is definitely not worth it. Though maybe we can take advantage of what's already been done and if we remove the `RevRefs` map, and pay the full price of iterating all refs when `refersTo` is called, we still have this feature. Although slower, it shouldn't take more than a few 100's of milliseconds even on a big project. Which means the feature is usable, at least for most small to medium sized projects, at no extra cost for people who do not use it.

Would this be acceptable ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93829/new/

https://reviews.llvm.org/D93829



More information about the cfe-commits mailing list