[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

[Utkarsh Saxena via Phabricator via cfe-commits]

usaxena95 added a comment.

In D94785#2501312 <https://reviews.llvm.org/D94785#2501312>, @njames93 wrote:

> My only question is does this try and index lambdas, under the hood they are declared as a CXXRecordDecl, defined in function scope?

I would not expect that to happen as it is an anonymous class and we filter those in the beginning of `shouldCollectSymbol`.
Added tests to test this.

Although now that I enabled this in all SymbolCollectorTests, this causes a regression in RefContainers.

  void f2() {
        (void) $ref1a[[f1]](1);
        auto fptr = &$ref1b[[f1]];
      }

`&f1` is contained in `fptr` instead of `f2`. No immediate ideas why would this happen. Will take a look into this next week.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94785/new/

https://reviews.llvm.org/D94785