[PATCH] D94474: [WIP][clang][cli] Test manual header search argument generation with round-trip

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 15 10:02:50 PST 2021


jansvoboda11 abandoned this revision.
jansvoboda11 added a comment.

Hmm, that would still require us to keep a list of options we've converted. It's better than hard-coding it like this patch does, but I'd like it to be more automatic.

I've updated D94472 <https://reviews.llvm.org/D94472> with my initial implementation of more hands-off solution. The gist is that the original `ArgList` instance constructs set of options the `CompilerInvocation` queries during parsing. This will tell us which options we should be able to generate and which we shouldn't need to copy from the original argument list to the new one via `AddAllArgsXxx`.

Abandoning this patch as per your suggestion to merge round-tripping with the actual command line generation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94474/new/

https://reviews.llvm.org/D94474



More information about the cfe-commits mailing list