[PATCH] D93453: [flang][driver] Add support for `-I`

Fri Jan 15 05:03:04 PST 2021

FarisRehman marked 2 inline comments as done.
FarisRehman added inline comments.

================
Comment at: flang/test/Flang-Driver/include-header.f90:38
+!-----------------------------------------------------
+! EXPECTED OUTPUT FOR /Inputs/ FOLDER SPECIFIED FIRST
+!-----------------------------------------------------
----------------
sameeranjoshi wrote:
> Nit - Shouldn't this be `Inputs/` starting with a `/` changes the meaning(at least on Linux systems) ?
I've fixed this, thanks.

================
Comment at: flang/test/Flang-Driver/include-header.f90:59
+#endif
+end
----------------
tskeith wrote:
> `-I` also is supposed to affect INCLUDE lines so it would be good to have a test for that too. They are handled during preprocessing and so can be tested the same way.
> 
> It also affects searching for .mod files but I think to test that requires semantics (i.e. to report an error if the module can't be found). It would be good to test that somewhere too.
Thanks, I've updated the test to check INCLUDE lines and added a new test for module files.
I've added some `.mod` files to the Inputs directory, however these files are not real module files and are just there for the test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93453/new/

https://reviews.llvm.org/D93453