[PATCH] D94735: CGDebugInfo: Drop unneeded line number for CreatedLimitedType

Thu Jan 14 21:33:45 PST 2021

dblaikie added a comment.

In D94735#2500132 <https://reviews.llvm.org/D94735#2500132>, @MaskRay wrote:

> In D94735#2500129 <https://reviews.llvm.org/D94735#2500129>, @dblaikie wrote:
>
>> Ah, seems I was confused by the patch title - it looks like these values aren't used for FlagFwdDecl records - forward declarations bail out 3356, not using the file/line created on 3338/3339.
>>
>> Seems like this change might lead to a situation of files but no line numbers, which seems a bit strange to me - well, at least for __va_list_tag, which isn't anymore associated with the file than with the line. Perhaps both should be addressed?
>
> `__va_list_tag` is synthesized by Clang `CreateX86_64ABIBuiltinVaListDecl` for `__builtin_va_arg`. I think giving it the filename of `CurLoc` is fine. Giving it the line of the `CurLoc` is arbitrary. `CurLoc` may be from a very unrelated thing.
>
> Emm.. The title was wrong. I did not read 3319 `if (T && !T->isForwardDecl())` carefully...

What makes the file less arbitrary than the line? They seem similarly arbitrary to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94735/new/

https://reviews.llvm.org/D94735