[PATCH] D94644: [Inliner] Inline alwaysinline calls first

Mircea Trofin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 14 09:45:23 PST 2021


mtrofin added a comment.

In D94644#2498638 <https://reviews.llvm.org/D94644#2498638>, @aeubanks wrote:

> It's not an emergency.
> The issue with InlineAdvisorAnalysis is that the ModuleInlineWrapperPass presets the InliningAdvisorMode of the InlineAdvisorAnalysis. We could force override it, but then what's the point of InlineAdvisorAnalysis? Can't we just create an InlineAdvisor in the pass itself rather than using a wrapper like InlineAdvisorAnalysis?

We need to have the advisor module-wide, because its goal is to track module-wide stats, which we leverage in the ML advisor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94644/new/

https://reviews.llvm.org/D94644



More information about the cfe-commits mailing list