[PATCH] D94682: [clang][cli] Parse Lang and CodeGen options separately

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:1831
+  MarshallingInfoString<LangOpts<"LaxVectorConversions">,
+                        !strconcat(open_cl.KeyPath, " ? LangOptions::LaxVectorConversionKind::None"
+                                                    " : LangOptions::LaxVectorConversionKind::All")>,
----------------
This replaces the conditional in `CompilerInvocation::setLangDefaults`.

The enum cases need to be fully qualified now, because we can't use `NormalizedValuesScope<"LangOptions::LaxVectorConversionKind">` due to the "arbitrary" expression for default value.


================
Comment at: clang/test/Frontend/diagnostics-order.c:12
 // CHECK-NEXT: note: use {{.*}} for {{.*}} standard
+// CHECK: warning: optimization level '-O999' is not supported
----------------
The order of these diagnostics depends on the order of argument parsing. Because we've moved `CodeGenOpts` parsing after `LangOpts`, this needs to be adjusted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94682/new/

https://reviews.llvm.org/D94682