[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added inline comments.


================
Comment at: clang/lib/Format/Format.cpp:819
+    Expanded.IndentCaseLabels = true;
+    Expanded.IndentCaseBlocks = false;
     break;
----------------
I guess its fine to define these defaults here but what if people turn them off in their config what will happen?


================
Comment at: clang/unittests/Format/FormatTest.cpp:13707
                WhitesmithsBraceStyle);
 
   verifyFormat("enum X\n"
----------------
timwoj wrote:
> MyDeveloperDay wrote:
> > any reason why this is being removed?
> This is an artifact of there not being any sort of actual guide for Whitesmiths. I have it set now to always indent the case labels (and it should just ignore the IndentCaseLabels option entirely, like it does for IndentCaseBlocks). I can certainly fix that option to work again though.
see the images from {D93806}, you are saying that anyone with bracewrappingsytle of Whitesmith cannot decide if they can or cannot indent case labels?

Could you show me a spec that show Whitesmiths is the other way around?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94500/new/

https://reviews.llvm.org/D94500