[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

[Tim Wojtulewicz via Phabricator via cfe-commits]

timwoj added inline comments.


================
Comment at: clang/lib/Format/TokenAnalyzer.cpp:71
                        Env.getFirstStartColumn(), Style, Encoding, Allocator,
-
                        IdentTable);
----------------
HazardyKnusperkeks wrote:
> Unrelated change (although I think it's good one).
Should I split that into a separate commit?


================
Comment at: clang/unittests/Format/FormatTest.cpp:13528
                "namespace B\n"
-               "  {\n"
+               "{\n"
                "class C;\n"
----------------
HazardyKnusperkeks wrote:
> So until now it has formatted that always wrong?
Hm, that's a good question. I'll have to think about that one. I guess for Whitesmiths and it's always wanting to indent braces, this should be fixed back to way that it was.


================
Comment at: clang/unittests/Format/FormatTest.cpp:13707
                WhitesmithsBraceStyle);
 
   verifyFormat("enum X\n"
----------------
MyDeveloperDay wrote:
> any reason why this is being removed?
This is an artifact of there not being any sort of actual guide for Whitesmiths. I have it set now to always indent the case labels (and it should just ignore the IndentCaseLabels option entirely, like it does for IndentCaseBlocks). I can certainly fix that option to work again though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94500/new/

https://reviews.llvm.org/D94500