[clang-tools-extra] a4f3866 - [clangd] Remove "decision-forest-base" experimental flag.
Utkarsh Saxena via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 13 08:55:48 PST 2021
Author: Utkarsh Saxena
Date: 2021-01-13T17:54:38+01:00
New Revision: a4f386688239b06e09f28fd31f93bf761aa9c76f
URL: https://github.com/llvm/llvm-project/commit/a4f386688239b06e09f28fd31f93bf761aa9c76f
DIFF: https://github.com/llvm/llvm-project/commit/a4f386688239b06e09f28fd31f93bf761aa9c76f.diff
LOG: [clangd] Remove "decision-forest-base" experimental flag.
The value of this flag can only be fine tuned by using A/B testing on large
user base.
We do not expect individual users to use and fine tune this flag.
Differential Revision: https://reviews.llvm.org/D94513
Added:
Modified:
clang-tools-extra/clangd/tool/ClangdMain.cpp
Removed:
################################################################################
diff --git a/clang-tools-extra/clangd/tool/ClangdMain.cpp b/clang-tools-extra/clangd/tool/ClangdMain.cpp
index d2c52cf61c53..9c75cafdb08e 100644
--- a/clang-tools-extra/clangd/tool/ClangdMain.cpp
+++ b/clang-tools-extra/clangd/tool/ClangdMain.cpp
@@ -194,14 +194,6 @@ opt<CodeCompleteOptions::CodeCompletionRankingModel> RankingModel{
Hidden,
};
-opt<float> DecisionForestBase{
- "decision-forest-base",
- cat(Features),
- desc("Base for exponentiating the prediction from DecisionForest."),
- init(CodeCompleteOptions().DecisionForestBase),
- Hidden,
-};
-
// FIXME: also support "plain" style where signatures are always omitted.
enum CompletionStyleFlag { Detailed, Bundled };
opt<CompletionStyleFlag> CompletionStyle{
@@ -841,7 +833,6 @@ clangd accepts flags on the commandline, and in the CLANGD_FLAGS environment var
Opts.CodeComplete.AllScopes = AllScopesCompletion;
Opts.CodeComplete.RunParser = CodeCompletionParse;
Opts.CodeComplete.RankingModel = RankingModel;
- Opts.CodeComplete.DecisionForestBase = DecisionForestBase;
RealThreadsafeFS TFS;
std::vector<std::unique_ptr<config::Provider>> ProviderStack;
More information about the cfe-commits
mailing list