[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 12 16:08:58 PST 2021


compnerd added a comment.

I think that it makes more sense to ignore the `aapcs-vfp` calling convention attribute (returning `CCCR_Ignore`), and warn on the `aapcs`.  The redundant calling convention attribute does nothing, and I think that simply ignoring it would solve your issue.  However, changing the calling convention to `aapcs` would break interoperability, so warning on that seems reasonable still.  I think that if Wine is willing to adjust their use of the attribute, that would really be nicer - it allows us to keep the behaviour as close to MSVC as possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94364/new/

https://reviews.llvm.org/D94364



More information about the cfe-commits mailing list