[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber
Adrian Prantl via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 12 15:35:56 PST 2021
aprantl added a comment.
I like that this makes getLineNumber behave less "magic". I'm slightly worried that this isn't quite as NFC as think (and the other cases are just not caught by the testsuite). Perhaps you could compile Clang (and a sample of Clang's ObjC(xx) tests) with the patch and diff the dwarfdump output?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94391/new/
https://reviews.llvm.org/D94391
More information about the cfe-commits
mailing list