[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 12 13:55:49 PST 2021


MaskRay added a comment.

I removed `CurLoc` from call sites and tried a stage 2 build.

  0x00062228:   DW_TAG_structure_type
                  DW_AT_calling_convention        (DW_CC_pass_by_value)
                  DW_AT_name      ("__va_list_tag")
                  DW_AT_byte_size (0x18)
                  DW_AT_decl_file ("/home/maskray/llvm/clang/tools/driver/driver.cpp")
                  DW_AT_decl_line (23)

driver.cpp:23 is a `#include`. So this looks strange. The DW_AT_decl_file/DW_AT_decl_line attributes are undesired due to `CurLoc` getLineNumber.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94391/new/

https://reviews.llvm.org/D94391



More information about the cfe-commits mailing list