[PATCH] D94537: [IR] move nomerge attribute from function declaration/definition to callsites

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 12 11:41:09 PST 2021


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, thanks!



================
Comment at: clang/lib/CodeGen/CGCall.cpp:1973
       }
-      if (!AttrOnCallSite && TargetDecl->hasAttr<NoMergeAttr>())
         FuncAttrs.addAttribute(llvm::Attribute::NoMerge);
----------------
This is the key change, I think this is worth a comment. Now we only place LLVM nomerge attributes on call sites, never functions, and this allows them to work on indirect virtual function calls.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94537/new/

https://reviews.llvm.org/D94537



More information about the cfe-commits mailing list