[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

Tue Jan 12 09:59:47 PST 2021

xazax.hun added a comment.

In D93224#2493434 <https://reviews.llvm.org/D93224#2493434>, @steakhal wrote:

> How should I continue to get this working with CTU?

We have two CTU modes. One loading the dump and the other loading from AST source file. I assume that you refer to the former? Could you validate that this solution works for the latter?
If we cannot make CTU fully functional, is it possible to at least make it work for the current TU (as opposed to functions inlined from another TU)?

While it would be great to have a fully working solution, not having macro expansions in a single relatively narrow scenario might worth the trade-off to get rid of the related bugs and throw out a half-baked reimplementation of the preprocessor.

If we really want to make it work for the CTU mode with dumps, we could dump the macro expansions to a separate file together with the AST and read it back for the error reporting.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93224/new/

https://reviews.llvm.org/D93224