[PATCH] D94488: [clang][cli] Port more CodeGenOptions to marshalling infrastructure

Tue Jan 12 03:39:50 PST 2021

jansvoboda11 added inline comments.

================
Comment at: clang/include/clang/Driver/Options.td:1165
+  ChangedBy<PosFlag, [LinkOption]>, ResetBy<NegFlag>>;
+defm test_coverage : BoolFOption<"test-coverage",
+  "CodeGenOpts.EmitGcovNotes", DefaultsToFalse,
----------------
The `profile_arcs` and `test_coverage` options were moved here so that `fprofile_filter_files_EQ` and `fprofile_exclude_files_EQ` can refer to their keypaths.

================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1146
-  Opts.SSPBufferSize =
-      getLastArgIntValue(Args, OPT_stack_protector_buffer_size, 8, Diags);
-
----------------
This piece of code should've been removed in D84669 which added marshalling info to `stack_protector_buffer_size`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94488/new/

https://reviews.llvm.org/D94488