[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

Pengfei Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 11 21:54:31 PST 2021


pengfei added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmt.cpp:2488
+      if (Clobber == "eax") {
+        std::string::size_type position = Constraints.find("={eax}");
+        if (position != std::string::npos) {
----------------
`={eax}` is set in `X86_32TargetCodeGenInfo::addReturnRegisterOutputs`, which also handles `EAX:EDX` case by `=A`. I think it's better handle it in the function to cover the other case as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94466/new/

https://reviews.llvm.org/D94466



More information about the cfe-commits mailing list