[PATCH] D94438: Fis for Assertion failure on dependent expression.

[Erich Keane via Phabricator via cfe-commits]

erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.

Fix looks fine, I'm on the fence about how to handle the test, whether it is valuable to convert it to a C++ test and omit the #ifdef/extra run line, or leave it as it is (without the 2nd run with Wmost).

I'll leave the opinion here to other reviewers/submitter to deal with before commit.



================
Comment at: clang/test/Sema/builtin-returnaddress.c:3
 // RUN: %clang_cc1 -fsyntax-only -Wmost -verify %s
+// RUN: %clang_cc1 -x c++ -fsyntax-only -Wframe-address -verify %s
+// RUN: %clang_cc1 -x c++ -fsyntax-only -Wmost -verify %s
----------------
I don't think the -Wmost test 'RUN' line is valuable for the C++ mode, it is simply validating that this diagnostic is in Wmost mode (which running in C mode is sufficient).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94438/new/

https://reviews.llvm.org/D94438