[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

Mikhail Maltsev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 11 02:31:28 PST 2021


miyuki added inline comments.


================
Comment at: clang/include/clang/AST/DeclObjC.h:660
+  /// Location of the left and right angle brackets.
+  alignas(ObjCTypeParamDecl *) SourceRange Brackets;
   /// The number of parameters in the list, which are tail-allocated.
----------------
aprantl wrote:
> Can you add a comment here explaining why the alignas is needed here? It's not obvious from the context.
Actually, `alignas` is not needed here. I've removed it and updated the commit message to explain why.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94224/new/

https://reviews.llvm.org/D94224



More information about the cfe-commits mailing list