[PATCH] D94382: [clangd] Avoid recusion in TargetFinder::add()

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 10 17:53:03 PST 2021


nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:790
 
+TEST_F(TargetDeclTest, TypedefCascade) {
+  Code = R"cpp(
----------------
This test case is not strictly related to the bug, but it adds test coverage for a scenario that I think is important, and that could be broken if we took a different approach to fixing this bug (see [my comments on the issue](https://github.com/clangd/clangd/issues/633#issuecomment-757586253) for details).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94382/new/

https://reviews.llvm.org/D94382



More information about the cfe-commits mailing list