[PATCH] D94337: Add cuda header type for cuh files

Justin Lebar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 10 17:39:55 PST 2021


jlebar added a comment.

Hi, welcome!  Thank you for the careful and well-motivated first commit.  (I also see https://github.com/ccache/ccache/issues/772, hooray for noticing that...)

I am also not 100% sure how to write a test, but I think you may be able to observe the effect of your driver changes by running `clang -###`.  I'd expect you'd then see `-x cuda` in the output?

Same for the `.cuhi` change; I presume that with `-###` you'll be able to see that the driver is building a PCH with output name `.cuhi` even if that would crash if it actually went through.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94337/new/

https://reviews.llvm.org/D94337



More information about the cfe-commits mailing list