[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 10 12:44:29 PST 2021


HazardyKnusperkeks added a comment.

Apart from my inline comment and the pre merge check this is superb. (I will not accept it, until we have reached a conclusion for the documentation.)



================
Comment at: clang/docs/ClangFormatStyleOptions.rst:338
+
+      int aaaa = 12;
+      int b    = 23;
----------------
This are now the examples from aligning the assignment. We now know that the rules for the alignments are the same, but someone new to it, just reading the documentation may be puzzled.

As @MyDeveloperDay said, most likely the script for generation has to be adapted?

The question here is now doing it now, or in a different change? It should happen before LLVM 12 will be released.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93986/new/

https://reviews.llvm.org/D93986



More information about the cfe-commits mailing list