[PATCH] D87147: PR-47391 : Two DIFile entries are describing the same file two different ways

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 10 10:59:45 PST 2021


MaskRay added inline comments.


================
Comment at: clang/test/CodeGenCXX/difile_entry.cpp:1
+// RUN: rm -rf %t/test_dir
+// RUN: mkdir -p %t/test_dir
----------------
MaskRay wrote:
> @umesh.kalappa0 Can you clarify how this test demonstrates the behavior difference?
> 
> Reverting the code part does not make the test fail.
Seems that absolute path needs to be used. `../test_dir/difile_entry.cpp` cannot demonstrate the difference. I'll improve the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87147/new/

https://reviews.llvm.org/D87147



More information about the cfe-commits mailing list