[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 8 09:37:37 PST 2021


ABataev added a comment.

In D94315#2487150 <https://reviews.llvm.org/D94315#2487150>, @JonChesterfield wrote:

> I'm guessing we're using the function boundary as a compiler barrier. That seems fragile in the face of improving cross-function optimisation.

Looks like applying inaccessiblemem_or_argmemonly attribute to the OpenMP functions is way too optimistic since we still can access this (inaccessible) memory using other OpenMP functions. Not sure about the semantics of this attribute, though.

> What is the invariant we want around entry to a data environment, which happens to be met by a function boundary?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94315/new/

https://reviews.llvm.org/D94315



More information about the cfe-commits mailing list