[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 8 07:18:50 PST 2021


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM!



================
Comment at: clang-tools-extra/clangd/unittests/tweaks/ExpandAutoTypeTests.cpp:68
 
+  EXPECT_EQ(apply("ns::Class * foo() { au^to c = foo(); }"),
+            "ns::Class * foo() { ns::Class * c = foo(); }");
----------------
can you also test for shortening? e.g.

```
void ns::Func() { aut^o x = new ns::Class::Nested{}; }
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94259/new/

https://reviews.llvm.org/D94259



More information about the cfe-commits mailing list