[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

[Whisperity via Phabricator via cfe-commits]

whisperity added a comment.

I was just about to write an issue to the CoreGuidelines project, but I was @vingeldal has posted about "relatedness" before me: https://github.com/isocpp/CppCoreGuidelines/issues/1579. It was in the list of //closed// issues.

Herb Sutter has changed the rule's title to //"Avoid adjacent parameters of the same type when changing the argument order would change meaning"//. Now the phrase `related` has been removed from the title, and the body of the rule does not contain any mention to this phrase either.

//`change of meaning`// is still hard to prove from a Tidy standpoint (or could be incomputable to prove in the first place...), but a concept that can be grasped with much less mental effort.

The guideline itself still says that the //Enforcement// is to simply warn if two parameters have the same type. We are doing much more here already with making the Tidy output much more user friendly and less bloatful.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69560/new/

https://reviews.llvm.org/D69560