[PATCH] D94289: [clangd] Add go-to-def metric.

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:375
           VirtualMethods.insert(getSymbolID(CMD));
+          LocateASTReferentMetric.record(1, "go-to-overrides");
+        }
----------------
name could be a bit more explicit, particularly I'd confuse it with go-to on the override keyword.

Maybe `method-to-override` and `method-to-base`?


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:407
     // it's more useful to navigate to the template declaration.
     if (auto *CTSD = dyn_cast<ClassTemplateSpecializationDecl>(D)) {
       if (TouchedIdentifier &&
----------------
template-specialization-to-primary?


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:426
              ID->getName() == TouchedIdentifier->text(SM)))
           AddResultDecl(ID);
 
----------------
objc-category-to-class?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94289/new/

https://reviews.llvm.org/D94289