[PATCH] D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation.

Kareem Ergawy via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 7 23:18:35 PST 2021


ergawy updated this revision to Diff 315302.
ergawy marked 4 inline comments as done.
ergawy added a comment.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.

Handle review comments:

- Use different value map for emitting SpecConstOperation.
- Small change in testing code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93591/new/

https://reviews.llvm.org/D93591

Files:
  clang-tools-extra/clangd/ClangdLSPServer.cpp
  clang-tools-extra/clangd/test/initialize-params.test
  mlir/include/mlir/Dialect/SPIRV/IR/SPIRVBase.td
  mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
  mlir/lib/Target/SPIRV/Deserialization.cpp
  mlir/lib/Target/SPIRV/Serialization.cpp
  mlir/test/Dialect/SPIRV/IR/structure-ops.mlir
  mlir/test/Target/SPIRV/spec-constant.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93591.315302.patch
Type: text/x-patch
Size: 16973 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210108/2e9a1425/attachment-0001.bin>


More information about the cfe-commits mailing list