[PATCH] D93638: [hip] Enable HIP compilation with `<complex`> on MSVC.

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 7 10:20:57 PST 2021


tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

In D93638#2483913 <https://reviews.llvm.org/D93638#2483913>, @hliao wrote:

> Forget that C function could be overloaded on Clang with overloadable
> extension. With that, we don't need to mark functions from `<ymath.h>` as HD.
> Instead, we could provide their device-side implementation directly.

Ah. It was the "C" part that I was missing. I was only thinking of C++/HIP/CUDA. I think we're on the same page now. LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93638/new/

https://reviews.llvm.org/D93638



More information about the cfe-commits mailing list