[PATCH] D93483: Add element-type to the Vector TypeLoc types.

[Florian Hahn via Phabricator via cfe-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks



================
Comment at: clang/include/clang/AST/TypeLoc.h:1756
+
+class VectorTypeLoc : public ConcreteTypeLoc<UnqualTypeLoc, VectorTypeLoc,
+                                             VectorType, VectorTypeLocInfo> {
----------------
erichkeane wrote:
> fhahn wrote:
> > Can we reuse/unify this with `MatrixTypeLoc`? And then have `MatrixTypeLoc` just deal with the row/column operands.
> Since these have to be ConcreteTypeLocs, I don't think the matrix type can directly inherit from it, but it can do something very similar.
Oh right, that's a shame, given there already is a `MatrixTypeLoc`, which essentially does the same thing, but it also carries locations for the row and column operands.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93483/new/

https://reviews.llvm.org/D93483