[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 7 07:36:51 PST 2021


HazardyKnusperkeks added a comment.

In D94217#2483925 <https://reviews.llvm.org/D94217#2483925>, @rjelonek wrote:

> Currently at work we use Embarcadero Builder C++

I'm very sorry for you! (As someone who has (had?) also to use it.)

> In builder all above #pragma hdrstop is a precompiled header. And we have this #pragma at almost all cpp files, so mainInclude is ignored because is in second include block.
>
> `#pragma hdrstop( "c:\\projects\\include\\myinc.pch" )`
> This form shouldn't be handled

Why not? I don't know if `bcc` does support it, but `MSVC` does. So I think it definitely should support both, or none.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94217/new/

https://reviews.llvm.org/D94217



More information about the cfe-commits mailing list