[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

David Sherwood via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 7 00:30:25 PST 2021


david-arm added inline comments.


================
Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:751-753
+          // they effectively want vectorization disabled. We leave the
+          // scalable flag unspecified in this case to avoid setting the
+          // vectorize.enable flag later on.
----------------
sdesmalen wrote:
> is that not something to fix in the code that conditionally sets vectorize.enable later on instead of working around it here?
I did originally try to do that, but I had trouble with it and found it broke other places too. It ended up being simpler to fix it here, but I can play around with it again. Even if this is still the simplest solution I can come back with a more detailed explanation at least!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89031/new/

https://reviews.llvm.org/D89031



More information about the cfe-commits mailing list