[PATCH] D93701: [clang][cli] NFC: Pass an ignoring DiagnosticsEngine instead of nullptr to ParseDiagnosticArgs

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 6 12:43:18 PST 2021

Previous message: [PATCH] D93701: [clang][cli] NFC: Pass an ignoring DiagnosticsEngine instead of nullptr to ParseDiagnosticArgs
Next message: [PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

dexonsmith added a comment.

With the above adjustment, this LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93701/new/

https://reviews.llvm.org/D93701

Previous message: [PATCH] D93701: [clang][cli] NFC: Pass an ignoring DiagnosticsEngine instead of nullptr to ParseDiagnosticArgs
Next message: [PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the cfe-commits mailing list