[PATCH] D93587: [hip] Fix HIP version parsing.

[Michael Liao via Phabricator via cfe-commits]

hliao marked an inline comment as done.
hliao added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:97
   for (auto Part : VersionParts) {
     auto Splits = Part.split('=');
+    if (Splits.first == "HIP_VERSION_MAJOR") {
----------------
tra wrote:
> `Part.trim().split()` (or, maybe, `rtrim()`if you only care about EOL) would save you trimming in each individual case.
sure, as that file is auto-gen so far, we could simplify the unnecessary parsing so far. The EOL is the only issue so far.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93587/new/

https://reviews.llvm.org/D93587