[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

[Andrzej Warzynski via Phabricator via cfe-commits]

awarzynski created this revision.
Herald added a subscriber: dang.
awarzynski requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

The help text for `-I` was recently expanded in this commit:

- 8dd4e3ceb804a58bcf25e6856fc6fde5e1995a66 <https://reviews.llvm.org/rG8dd4e3ceb804a58bcf25e6856fc6fde5e1995a66>

The updated version:

- describes the internal implementation in Clang, and
- is inconsistently long when compared to other options printed with `clang -help`.

We are now in the process of adding support for `-I` in Flang and this
expanded description is invalid as far as Flang is concerned (i.e. it
does not reflect Flang's internal implementation). See this review:

- https://reviews.llvm.org/D93453

This patch reverts the original change in Options.td. This way the
description of `-I` remains generic and valid for both Clang and Flang.

Clang's internal documentation for `-I` is available in
ClangCommandLineReference.rst (it's identical to what's being removed
here, so no information is lost).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94169

Files:
  clang/include/clang/Driver/Options.td


Index: clang/include/clang/Driver/Options.td
===================================================================
--- clang/include/clang/Driver/Options.td
+++ clang/include/clang/Driver/Options.td
@@ -649,12 +649,7 @@
              "remove current directory from include path">;
 def I : JoinedOrSeparate<["-"], "I">, Group<I_Group>,
     Flags<[CC1Option,CC1AsOption]>, MetaVarName<"<dir>">,
-    HelpText<"Add directory to include search path. If there are multiple -I "
-             "options, these directories are searched in the order they are "
-             "given before the standard system directories are searched. "
-             "If the same directory is in the SYSTEM include search paths, for "
-             "example if also specified with -isystem, the -I option will be "
-             "ignored">;
+    HelpText<"Add directory to include search path">;
 def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group<Link_Group>,
     MetaVarName<"<dir>">, HelpText<"Add directory to library search path">;
 def MD : Flag<["-"], "MD">, Group<M_Group>,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94169.314862.patch
Type: text/x-patch
Size: 1074 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210106/430f8177/attachment.bin>