[PATCH] D89490: Introduce __attribute__((darwin_abi))

Adrien Guinet via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 5 23:28:26 PST 2021


aguinet added a comment.

In D89490#2481306 <https://reviews.llvm.org/D89490#2481306>, @rjmccall wrote:

> I do feel like this is a terrible idea, sorry.  It's a *very* niche use case to be dedicating a new compiler feature to, and it's a feature that demands a lot from the internal compiler architecture in ways that other features don't.

I'd say it's as much as a niche use case as `__attribute__((ms_abi))`? But the "niche use case" is Wine, which I believe has a consequent user base. I'm not saying the goal of this patch is to be able to do Wine for ARM64/iOS, but I believe that will help make very helpful tools for developers that target that OS (and don't have access to development devices, that is, basically everyone not working at Apple).

> If you really need to build code with the Darwin ABI that runs on Linux, can you not achieve it by building with `-S` and then hacking up the resulting assembly files?

After having written this patch and looked at the differences in assembly, that seemed far from trivial to achieve. But I'd be happy to look at POC of this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89490/new/

https://reviews.llvm.org/D89490



More information about the cfe-commits mailing list