[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

[Alan Phipps via Phabricator via cfe-commits]

alanphipps marked an inline comment as done.
alanphipps added inline comments.


================
Comment at: llvm/test/tools/llvm-cov/branch-noShowBranch.test:3
+// RUN: llvm-profdata merge %S/Inputs/branch-c-general.proftext -o %t.profdata
+// RUN: llvm-cov show %S/Inputs/branch-c-general.o32l -instr-profile %t.profdata -path-equivalence=/tmp,%S %S/branch-c-general.c | FileCheck %s
+// RUN: llvm-cov report %S/Inputs/branch-c-general.o32l --show-branch-summary=false -instr-profile %t.profdata -show-functions -path-equivalence=/tmp,%S %S/branch-c-general.c | FileCheck %s -check-prefix=REPORT
----------------
dblaikie wrote:
> This test depends on another test file as input which is generally not done in the LLVM test suite - inputs to tests are placed in the "Inputs" subdirectory, rather than in the test directory itself. I realize a few other tests already here (demangle, hideUnexpectedSubviews, style, and threads) already do this - but it'd be good to not add more cases (& fix those existing cases where possible)
> 
> Could you fix this so this test (& possibly others, if you have the opportunity/bandwidth) doesn't depend on other test files, but only on files in the Inputs subdirectory?
Certainly I can do that -- I believe there are two other tests in which I did this other than this test: branch-export-json.txt and branch-export-lcov.test.  I will adjust those tests that I added within the next days but I don't think I have the bandwidth to change other tests that also do this.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84467/new/

https://reviews.llvm.org/D84467