[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer
Duncan P. N. Exon Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 5 11:30:43 PST 2021
dexonsmith added a comment.
In D93701#2479574 <https://reviews.llvm.org/D93701#2479574>, @jansvoboda11 wrote:
> In D93701#2477239 <https://reviews.llvm.org/D93701#2477239>, @jansvoboda11 wrote:
>
>> Another solution would be to create a "dummy" `DiagnosticsEngine` for the `ParseDiagnosticArgs` calls, but I didn't find a way to do that.
>
> Something like `CompilerInstance::createDiagnostics(new DiagnosticOptions(), new IgnoreDiagnostics())` could work. I'll give that a try.
I think you can also construct a `DiagnosticsEngine` directly on the stack, without going through `CompilerInstance`, if that helps.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93701/new/
https://reviews.llvm.org/D93701
More information about the cfe-commits
mailing list