[PATCH] D93354: [clang-tidy] Make clang-format and include-order-check coherent again

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 5 09:34:01 PST 2021


kadircet added a comment.

i thought clang-format was also putting angled includes and "OtherHeaders" into same category, by looking at:

  LLVMStyle.IncludeStyle.IncludeCategories = {
        {"^\"(llvm|llvm-c|clang|clang-c)/", 2, 0, false},
        {"^(<|\"(gtest|gmock|isl|json)/)", 3, 0, false},      // Starts with `<` or gtest/gmock...
        {".*", 1, 0, false}};

not sure why it is done so (stylistic preferences i suppose ...). it definitely makes sense for me to separate them into 2 different categories, but i wouldn't dare make that decision :D maybe ask on cfe-dev first to get some consensus.
but it would make sense to include isl and json in this list for now, i forgot to do that in the initial patch :(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93354/new/

https://reviews.llvm.org/D93354



More information about the cfe-commits mailing list