[PATCH] D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

Tue Jan 5 09:32:30 PST 2021

ymandel added a comment.

In D93637#2479576 <https://reviews.llvm.org/D93637#2479576>, @tdl-g wrote:

> Ah, if it's just an optimization that makes sense.  I still think it's worth having a test case to confirm that one of the specially-handled cases works.

Sure. I added one for unique pointer. but, just one -- i didn't add one per case. My logic is that since it's not part of the contract/API, we're really just using the (single) test to test the internal function `isSmartPointerType`, so one test is enough. That said, if you disagree, I'm fine with adding more tests. Its easy.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93637/new/

https://reviews.llvm.org/D93637